Usage example: second test fails - Githubissues

acvetkov / sinon-chrome

Testing chrome extensions with Node.js

ISC License

435 stars 46 forks source link

Usage example: second test fails #59

Closed phongvis closed 6 years ago

phongvis commented 7 years ago

I forked the project and tried to run the usage example but the second test is failed at assert.calledOnce(chrome.browserAction.setBadgeText);. The callback in chrome.tabs.query(params, callback); isn't invoked.

Here is my fork: https://github.com/phongvis/sinon-chrome with the following changes:

package.json: add test-background option for npm-run and install jsdom
the extension files are placed at examples/src
the test file is examples/background.test.js also in examples

Could you have a check? Thanks.

herodrigues commented 6 years ago

See https://github.com/acvetkov/sinon-chrome/issues/42