search

acvetkov / sinon-chrome

Testing chrome extensions with Node.js
ISC License
434 stars 46 forks source link

Fixed package main #71

Closed crimx closed 6 years ago

crimx commented 6 years ago

@acvetkov This is actually a tricky bug.

Previous versions (<=v.2.2.1) worked because module resolver loaded the index.js after failing resolving out/index.js in package.json .

While v2.2.2 and v2.2.3 worked because you accidentally published the source repo. There is actually an out/index.js. But require('sinon-chrome/extensions') and require('sinon-chrome/webextensions') break because they are also in ./out.

Perhaps you should npm publish within ./out?

acvetkov commented 6 years ago

v2.2.4

crimx commented 6 years ago

Looks good :+1: