search

acvetkov / sinon-chrome

Testing chrome extensions with Node.js
ISC License
434 stars 46 forks source link

Update to sinon@4 #75

Closed stoically closed 6 years ago

stoically commented 6 years ago

Hi, thanks for your work on sinon-chrome.

sinon@4.4.0 got a PR merged which introduces to get the return values of callbacks when yielding, which we rely on in our WebExtension tests. Would be awesome if you could update sinon.

However, sinon deprecated .reset in favor of explicitly calling .resetBehavior and .resetHistory. I've updated the code accordingly.

Best regards

acvetkov commented 6 years ago

Hi. Thank you for pr. I've published new version sinon-chrome@2.3.0