acvetkov / sinon-chrome

Testing chrome extensions with Node.js
ISC License
439 stars 48 forks source link

Sinon update and sandbox creation change to prevent deprecation warning #84

Closed stoically closed 5 years ago

stoically commented 5 years ago

When using sinon-chrome with sinon versions 5 and later the following deprecation warning pops up:

sandbox.create() is deprecated. Use default sandbox at sinon.sandbox or create new sandboxes with sinon.createSandbox()

According to the migration guide https://sinonjs.org/guides/migrating-to-5.0.html a change from sinon.sandbox.create to sinon.createSandbox is needed.

stoically commented 5 years ago

Thanks for merging! Would you consider publishing a new version with the change? Might need a major bump because of https://github.com/acvetkov/sinon-chrome/pull/76 - since passing in a old version of sinon without the createSandbox function will result in an error.

acvetkov commented 5 years ago

@stoically hi. thanks for pull request. checkout sinon-chrome 3.0.0

stoically commented 5 years ago

@acvetkov Thanks!