search

acvetkov / sinon-chrome

Testing chrome extensions with Node.js
ISC License
434 stars 46 forks source link

Reset sinon sandbox when flushing to prevent memory leak #85

Closed stoically closed 5 years ago

stoically commented 5 years ago

Since version 5, sinon is itself a sandbox. Creating stubs results in a memory leak if not restored properly, so we should do that when flush or reset is called.

acvetkov commented 5 years ago

hi. checkout v3.0.1

stoically commented 5 years ago

Thanks for the quick merge and release!