search

acxz / gym-ccc

Classic control gym environments with non-normalized and normalized observation vectors
GNU General Public License v3.0
3 stars 0 forks source link

Upstreaming changes in Gym #8

Open jkterry1 opened 3 years ago

jkterry1 commented 3 years ago

Hey,

As you may know, I'm the maintainer of OpenAI gym. Your changes are interesting, and I was hoping you could elaborate on why you made them. It seems like some of these should be upstreamed to Gym.

acxz commented 3 years ago

Thx for the interest! These changes are mostly to add/extend envs which are more suitable for tasks in the controls field. Primarily have continuous action spaces.

jkterry1 commented 3 years ago

If you'd like to create a PR for Gym introducing all these features as optional flags in the master environments I'd love to see it.

acxz commented 3 years ago

That sounds wonderful, I'm a bit busy at the moment, so not sure when I'll get the chance. But will def keep this in mind, when I get around to it.

acxz commented 1 year ago

I've been away from RL for some time and seems like Gymnasium is future of gym. Just caught up with it and the project motivation/goals and I'm really excited for the future!

I'll go ahead and incorporate the API changes, test these environments and make a issue (RFC)/associated PR into Gymnasium in the coming months.

Again, really excited for the Farama Foundation, you are doing some good, solid work, @jkterry1