acxz / pkgbuilds

PKGBUILDs for Arch Linux
25 stars 43 forks source link

[openvsp] format security compile error #142

Open x3oo opened 3 years ago

x3oo commented 3 years ago

[buttermelted@thinkpad ~]$ pacaur -Syue :: Synchronizing package databases... core is up to date extra is up to date community is up to date multilib is up to date repo-ck is up to date :: Starting full system upgrade... warning: linux-ck: local (5.12.19-1) is newer than repo-ck (5.12.18-1) warning: linux-ck-headers: local (5.12.19-1) is newer than repo-ck (5.12.18-1) there is nothing to do :: Starting AUR upgrade... :: electron6 is not present in AUR -- skipping :: gnome-getting-started-docs is not present in AUR -- skipping :: haskell-haddock-library1.9 is not present in AUR -- skipping :: libopenaptx is not present in AUR -- skipping :: python2-click is not present in AUR -- skipping :: python2-decorator is not present in AUR -- skipping :: python2-ipykernel is not present in AUR -- skipping :: python2-jupyter_client is not present in AUR -- skipping :: python2-jupyter_core is not present in AUR -- skipping :: python2-pickleshare is not present in AUR -- skipping :: resolving dependencies... :: looking for inter-conflicts...

AUR Packages (1) openvsp-3.25.0-1

:: Proceed with installation? [Y/n] :: Retrieving package(s)... update complete: /home/buttermelted/.cache/pacaur/openvsp :: openvsp PKGBUILD viewed :: Checking openvsp integrity... ==> Making package: openvsp 3.25.0-1 (Mon 23 Aug 2021 05:47:11 PM CEST) ==> Retrieving sources... -> Found openvsp-3.25.0 ==> Validating source files with sha256sums... openvsp-3.25.0 ... Passed :: Preparing openvsp... ==> Making package: openvsp 3.25.0-1 (Mon 23 Aug 2021 05:47:13 PM CEST) ==> WARNING: Skipping dependency checks. ==> Retrieving sources... -> Found openvsp-3.25.0 ==> WARNING: Skipping all source file integrity checks. ==> Extracting sources... -> Extracting openvsp-3.25.0 with bsdtar ==> Sources are ready. :: Building openvsp package(s)... ==> Making package: openvsp 3.25.0-1 (Mon 23 Aug 2021 05:47:17 PM CEST) ==> Checking runtime dependencies... ==> Checking buildtime dependencies... ==> WARNING: Using existing $srcdir/ tree ==> Removing existing $pkgdir/ directory... ==> Starting build()... -- Configuring done -- Generating done -- Build files have been written to: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs [ 20%] Built target EXPRPARSE [ 40%] Built target TRIANGLE [ 60%] Built target STEPCODE [ 80%] Built target LIBIGES [100%] Built target CMINPACK -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) CMake Warning (dev) at /usr/share/cmake-3.21/Modules/FindOpenGL.cmake:315 (message): Policy CMP0072 is not set: FindOpenGL prefers GLVND by default when available. Run "cmake --help-policy CMP0072" for policy details. Use the cmake_policy command to set the policy and suppress this warning.

FindOpenGL found both a legacy GL library:

OPENGL_gl_LIBRARY: /usr/lib/libGL.so

and GLVND libraries for OpenGL and GLX:

OPENGL_opengl_LIBRARY: /usr/lib/libOpenGL.so
OPENGL_glx_LIBRARY: /usr/lib/libGLX.so

OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for compatibility with CMake 3.10 and below the legacy GL library will be used. Call Stack (most recent call first): /usr/share/cmake-3.21/Modules/FindFLTK.cmake:87 (find_package) external/CMakeLists.txt:13 (FIND_PACKAGE) This warning is for project developers. Use -Wno-dev to suppress it.

-- GLM_INCLUDE_DIR = /usr/include -- Found Code-Eli version 0.3.6, and requested version 0.3.6 -- CMINPACK_LIBRARY /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/CMINPACK-prefix/lib64/libcminpack.a -- TRIANGLE_INCLUDE_DIR: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/include/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/include -- TRIANGLE_LIBRARIES: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/lib/libtriangle-api.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/lib/libtriangle.a CMake Deprecation Warning at external/angelscript/sdk/CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 2.8.12 will be removed from a future version of CMake.

Update the VERSION argument value or use a ... suffix to tell CMake that the project does not need compatibility with older versions.

-- Configuring angelscript 2.35.1 -- PINOCCHIO_INCLUDE_DIR /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/external/Pinocchio/Pinocchio -- Could NOT find SWIG (missing: SWIG_EXECUTABLE SWIG_DIR) SWIG not found, skipping API configurations -- CPPTEST_INCLUDE_DIRS /usr/include -- CPPTEST_LIBRARIES /usr/lib/libcpptest.so -- LIBXML2_INCLUDE_DIR /usr/include/libxml2 -- LIBXML2_LIBRARIES -- FLTK_FOUND -- FLTK_INCLUDE_DIR /usr/include -- FLTK_LIBRARIES /usr/lib/libfltk_images.so/usr/lib/libfltk_forms.so/usr/lib/libfltk_gl.so/usr/lib/libGL.so/usr/lib/libfltk.so/usr/lib/libSM.so/usr/lib/libICE.so/usr/lib/libX11.so/usr/lib/libXext.so/usr/lib/libm.so -- FLTK_FLUID_EXECUTABLE /usr/bin/fluid -- GLM_INCLUDE_DIR = /usr/include -- GLEW_INCLUDE_PATH /usr/include -- GLEW_LIBRARY /lib/libGLEW.so -- EIGEN3_INCLUDE_DIR = /usr/include/eigen3 -- CodeEli_INCLUDE_DIRS = /usr/include -- CMINPACK_INCLUDE_DIR /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/CMINPACK-prefix/include/cminpack-1 -- CMINPACK_LIBRARIES /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/CMINPACK-prefix/lib64/libcminpack.a -- STEPCODE_INCLUDE_DIR /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/stepcode/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/stepcode/base/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/stepcode/clstepcore/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/stepcode/cldai/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/stepcode/clutils/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/stepcode/cleditor/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/include/schemas/sdai_ap203 -- STEPCODE_LIBRARIES /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/lib/libsdai_ap203.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/lib/libstepeditor.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/lib/libstepcore.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/lib/libstepdai.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/lib/libsteputils.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/STEPCODE-prefix/src/STEPCODE/../sc-install/lib/libbase.a -- LIBIGES_LIBRARIES: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/LIBIGES-prefix/lib/libiges_static.a -- LIBIGES_INCLUDE_DIR: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/LIBIGES-prefix/include/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/LIBIGES-prefix/include/iges/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/LIBIGES-prefix/include/geom -- PYTHON_EXECUTABLE: -- PYTHON_LIBRARY: -- PYTHON_INCLUDE_DIR: -- PYTHON_INCLUDE_PATH: -- PYTHON_VERSION: -- TRIANGLE_INCLUDE_DIR: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/include/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/include -- TRIANGLE_LIBRARIES: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/lib/libtriangle-api.a/home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/TRIANGLE-prefix/lib/libtriangle.a -- EXPRPARSE_LIBRARY: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/EXPRPARSE-prefix/lib/libexprparse.a -- EXPRPARSE_INCLUDE_PATH: /home/buttermelted/.cache/pacaur/openvsp/src/buildlibs/EXPRPARSE-prefix/include -- Configuring done CMake Warning (dev) at vsp/CMakeLists.txt:43 (ADD_EXECUTABLE): Policy CMP0115 is not set: Source file extensions must be explicit. Run "cmake --help-policy CMP0115" for policy details. Use the cmake_policy command to set the policy and suppress this warning.

File:

/home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp/main.h.in

This warning is for project developers. Use -Wno-dev to suppress it.

-- Generating done -- Build files have been written to: /home/buttermelted/.cache/pacaur/openvsp/src/build Consolidate compiler generated dependencies of target glfont2 [ 0%] Built target glfont2 Consolidate compiler generated dependencies of target stb_image [ 1%] Built target stb_image Consolidate compiler generated dependencies of target cartesian [ 1%] Built target cartesian Consolidate compiler generated dependencies of target sixseries [ 2%] Built target sixseries Consolidate compiler generated dependencies of target tritri [ 3%] Built target tritri Consolidate compiler generated dependencies of target clipper [ 4%] Built target clipper Consolidate compiler generated dependencies of target wavedragEL [ 4%] Built target wavedragEL Consolidate compiler generated dependencies of target pinocchio [ 8%] Built target pinocchio Consolidate compiler generated dependencies of target Angelscript [ 17%] Built target Angelscript Consolidate compiler generated dependencies of target vsp_graphic [ 27%] Built target vsp_graphic Consolidate compiler generated dependencies of target util [ 33%] Built target util Consolidate compiler generated dependencies of target xmlvsp [ 34%] Built target xmlvsp Consolidate compiler generated dependencies of target geom_core [ 51%] Built target geom_core Consolidate compiler generated dependencies of target cfd_mesh [ 56%] Built target cfd_mesh Consolidate compiler generated dependencies of target gui_and_draw [ 75%] Built target gui_and_draw Consolidate compiler generated dependencies of target gui_interface_g [ 75%] Built target gui_interface_g Consolidate compiler generated dependencies of target geom_api_g [ 75%] Built target geom_api_g Consolidate compiler generated dependencies of target geom_api [ 76%] Built target geom_api Consolidate compiler generated dependencies of target vspscript [ 76%] Built target vspscript Consolidate compiler generated dependencies of target apitest [ 78%] Built target apitest Consolidate compiler generated dependencies of target apitest_g [ 80%] Built target apitest_g Consolidate compiler generated dependencies of target vsp [ 80%] Built target vsp Consolidate compiler generated dependencies of target vspaero [ 80%] Building CXX object vsp_aero/solver/CMakeFiles/vspaero.dir/ComponentGroup.C.o In file included from /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/utils.H:17, from /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.H:15, from /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:7: /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/VSPAERO_TYPES.H: In instantiation of ‘void PRINTF(const char, const Args& ...) [with Args = {}]’: /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:461:15: required from here /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/VSPAERO_TYPES.H:76:9: error: format not a string literal and no format arguments [-Werror=format-security] 76 | printf(format, Argument(args) ...); | ~~^~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C: In member function ‘void COMPONENT_GROUP::LoadData(FILE)’: /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:789:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 789 | fscanf(File,"GroupName = %s \n",GroupName); | ~~^~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:793:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 793 | fscanf(File,"NumberOfComponents = %d \n",&NumberOfComponents); | ~~^~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:801:14: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 801 | fscanf(File,"%d \n",&(ComponentList[i])); | ~~^~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:805:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 805 | fscanf(File,"GeometryIsFixed = %d \n",&GeometryIsFixed); | ~~^~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:809:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 809 | fscanf(File,"GeometryIsDynamic = %d \n",&GeometryIsDynamic); | ~~^~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:813:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 813 | fscanf(File,"GeometryIsARotor = %d \n",&GeometryIsARotor); | ~~^~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:817:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 817 | fscanf(File,"RotorDiameter = %lf \n",&RotorDiameter); | ~~^~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:821:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 821 | fscanf(File,"OVec = %lf %lf %lf \n",&(OVec[0]),&(OVec[1]),&(OVec[2])); | ~~^~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:825:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 825 | fscanf(File,"RVec = %lf %lf %lf \n",&(RVec[0]),&(RVec[1]),&(RVec[2])); | ~~^~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:829:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 829 | fscanf(File,"Velocity = %lf %lf %lf \n",&(UserInputVelocity[0]),&(UserInputVelocity[1]),&(UserInputVelocity[2])); | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:833:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 833 | fscanf(File,"Acceleration = %lf %lf %lf \n",&(UserInputAcceleration[0]), &(UserInputAcceleration[1]), &(UserInputAcceleration[2])); | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:835:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 835 | fscanf(File,"Omega = %lf \n",&Omega); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:839:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 839 | fscanf(File,"Mass = %lf \n",&Mass); | ~~^~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:841:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 841 | fscanf(File,"Ixx = %lf \n",&Ixx); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:843:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 843 | fscanf(File,"Iyy = %lf \n",&Iyy); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:845:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 845 | fscanf(File,"Izz = %lf \n",&Izz); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:847:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 847 | fscanf(File,"Ixy = %lf \n",&Ixy); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:849:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 849 | fscanf(File,"Ixz = %lf \n",&Ixz); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:851:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 851 | fscanf(File,"Iyz = %lf \n",&Iyz); | ~~^~~~~~~ cc1plus: some warnings being treated as errors make[2]: [vsp_aero/solver/CMakeFiles/vspaero.dir/build.make:90: vsp_aero/solver/CMakeFiles/vspaero.dir/ComponentGroup.C.o] Error 1 make[1]: [CMakeFiles/Makefile2:1900: vsp_aero/solver/CMakeFiles/vspaero.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... :: failed to build openvsp package(s)

acxz commented 3 years ago

Hmm I cannot seem to reproduce this. Can you try with a clean build and make sure your Arch is fully updated?

x3oo commented 3 years ago

rm -rf openvsp/ pacaur -Syu .... 825 | fscanf(File,"RVec = %lf %lf %lf \n",&(RVec[0]),&(RVec[1]),&(RVec_[2])); | ~~^~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:829:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 829 | fscanf(File,"Velocity = %lf %lf %lf \n",&(UserInputVelocity[0]),&(UserInputVelocity[1]),&(UserInputVelocity[2])); | ~~^~~~~~~~~~~~~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:833:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 833 | fscanf(File,"Acceleration = %lf %lf %lf \n",&(UserInputAcceleration[0]), &(UserInputAcceleration[1]), &(UserInputAcceleration[2])); | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:835:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 835 | fscanf(File,"Omega = %lf \n",&Omega); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:839:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 839 | fscanf(File,"Mass = %lf \n",&Mass); | ~~^~~~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:841:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 841 | fscanf(File,"Ixx = %lf \n",&Ixx); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:843:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 843 | fscanf(File,"Iyy = %lf \n",&Iyy); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:845:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 845 | fscanf(File,"Izz = %lf \n",&Izz); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:847:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 847 | fscanf(File,"Ixy = %lf \n",&Ixy); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:849:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 849 | fscanf(File,"Ixz = %lf \n",&Ixz); | ~~^~~~~~~ /home/buttermelted/.cache/pacaur/openvsp/src/OpenVSP-OpenVSP_3.25.0/src/vsp_aero/solver/ComponentGroup.C:851:11: warning: ignoring return value of ‘int fscanf(FILE, const char, ...)’ declared with attribute ‘warn_unusedresult’ [-Wunused-result] 851 | fscanf(File,"Iyz = %lf \n",&Iyz); | ~~^~~~~~~ cc1plus: some warnings being treated as errors make[2]: [vsp_aero/solver/CMakeFiles/vspaero.dir/build.make:90: vsp_aero/solver/CMakeFiles/vspaero.dir/ComponentGroup.C.o] Error 1 make[1]: [CMakeFiles/Makefile2:1927: vsp_aero/solver/CMakeFiles/vspaero.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... :: failed to build openvsp package(s)

acxz commented 3 years ago

Can you post the full build log? It seems that the line with the error is not visible in your latest comment.

As for the error from your first comment this webpage seems related: https://stackoverflow.com/questions/17260409/fprintf-error-format-not-a-string-literal-and-no-format-arguments-werror-for

As for the fact that the clean didn't work, I am confused. Can you try a manual makepkg or a different AUR helper like yay?

x3oo commented 3 years ago

https://pastebin.pl/view/cc49a8ca

x3oo commented 3 years ago

CFLAGS="-O2 -pipe -fno-plt -fexceptions \ -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \ -fstack-clash-protection -fcf-protection" CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"

those are my compiler flags, still doesnt work. i dont quite understand, so, openvsp comes now with security bugs? this is newly introduced then because before it worked fine.

x3oo commented 3 years ago

@acxz why dont you just give me your cflags?

acxz commented 3 years ago

why dont you just give me your cflags?

From /etc/makepkg.conf:

CPPFLAGS="-D_FORTIFY_SOURCE=2"
CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt"
CXXFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"

I do not have -Werror=format-security.

this is newly introduced then because before it worked fine.

Seems so: https://github.com/OpenVSP/OpenVSP/commit/406d92304bd05a41f75280175799a36cc354f324#diff-7cafe6ca1c1cd0a10789daddf145fda0b71ca0bcb176f6e063684b51469db725R76

I urge you to make an upstream PR if you want this issue resolved.

x3oo commented 3 years ago

removing -Wformat -Werror=format-security solved the issue, damn that took so much time to solve. this should be a potential security bug? posted it upstream

x3oo commented 3 years ago

since i dont know much about compiling, those flags must have been in one of the arch guides recommended

acxz commented 3 years ago

I'll go ahead and close this issue, since I don't believe -Werror=format-security is a default setting on Arch, but yeah would be nice if the underlying issue can be solved by upstream.

Thx for reporting! (upstream issue for future ref: https://github.com/OpenVSP/OpenVSP/issues/198)

acxz commented 3 years ago

reopened as @vldw and @DavidAnderegg are experiencing the same issue and a patch should be made to address this.

vldw commented 3 years ago

I have removed the -Werror=format-security from /etc/makepkg.conf and it compiled I am using the default manjaro flags

acxz commented 3 years ago

Ah it might be that default arch doesn't have -Werror=format-security but manjaro does. @DavidAnderegg can you confirm what system you are running on?

x3oo commented 3 years ago

Fundamentally it's a security warning and should be fixed upstream. Archlinux doesn't have this flag by default. Nonetheless it seems to be good practice.

DavidAnderegg commented 3 years ago

Ah it might be that default arch doesn't have -Werror=format-security but manjaro does. @DavidAnderegg can you confirm what system you are running on?

@acxz I am running default arch

AkshaySiramdas commented 2 years ago

I am running arch and encountered the same issue. Removing -Werror=format-security from /etc/makepkg.conf and it compiled.

System : 5.14.12-arch1-1 AUR helper : paru

thojDufour commented 2 years ago

I'm also running default Arch and the flag -Werror=format-security was also in my /etc/makepkg.conf. It compiled after removing this flag.

Kernel: 5.15.2-arch1-1 AUR helper: paru

acxz commented 2 years ago

Just want to leave the link to the official /etc/makepkg.conf here: https://gitlab.archlinux.org/archlinux/devtools/-/blob/20220126/makepkg-x86_64.conf

(It does have -Werror=format-security) my apologizes.

acxz commented 2 years ago

patched with a902b00

vldw commented 2 years ago

I have tried installing openvsp again with yay -Syu openvsp and deleted the flags mentioned in the previous thread namely the -Werror=format-security flag from /etc/makepkg.confand it will still not compile.

openvsp.log here is the log where it failed to compile:


[ 54%] Built target vspaero
make[2]: *** [util/CMakeFiles/util.dir/build.make:398: util/CMakeFiles/util.dir/VspSurf.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:837: util/CMakeFiles/util.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: openvsp
acxz commented 2 years ago

The log file you have submitted is not complete. Please run the following command to obtain the full log: yay -Syu openvsp |& tee openvsp.log.

vldw commented 2 years ago

here is the log : openvsp.log

acxz commented 2 years ago

The error in your log is different from this issue. Reopening other issue.