search

acxz / pkgbuilds

PKGBUILDs for Arch Linux
25 stars 44 forks source link

[python-hydra-core] uses antlr 4.9.3 while python-antlr4 is 4.11.1-1 #212

Open 4rozenwolves opened 1 year ago

4rozenwolves commented 1 year ago

Hydra uses an internal antlr.

This makes it not compatible with antlr installed in the system. One solution is to replace the internal antlr to use system antlr, as done in python-omegaconf.

4rozenwolves commented 1 year ago

I added the following code in the pkgbuild:

prepare() {
  cd "${srcdir}/${_pkgname}-${pkgver}"
  sed -i 's/join(root_dir, "bin\/antlr-4.9.3-complete.jar")/"\/usr\/share\/java\/antlr-complete.jar"/' 'build_helpers/build_helpers.py'
}
acxz commented 1 year ago

Personally, I believe that if upstream wants to use their own packaged antlr4, then as packagers we should respect that (assuming that there are no other issues due to that decision). If someone could make an upstream issue that requests the option to use system installed antlr4 then we can get the reception of upstream to see if they would be open to that.

acxz commented 1 year ago

patched with #223

acxz commented 1 year ago

keeping this open until the patch is no longer needed