acxz / pkgbuilds

PKGBUILDs for Arch Linux
25 stars 43 forks source link

[python-torch-sparse] not build successfully #227

Closed nihil39 closed 1 year ago

nihil39 commented 1 year ago

Hi, I get this error while building python torch sparse 0.6.16-1

In file included from csrc/cpu/diag_cpu.cpp:3:
csrc/cpu/utils.h:4:10: fatal error: parallel_hashmap/phmap.h: No such file or directory
    4 | #include "parallel_hashmap/phmap.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/usr/bin/gcc' failed with exit code 1

ERROR Backend subprocess exited when trying to invoke build_wheel
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: python-torch-sparse

I'm trying to build this package as a dependency of pytorch geometric, a previous version of this package, now unmaintained can be found here

Thank you.

nihil39 commented 1 year ago

I think some dependencies should be added in the PKGBUILD, at least python gcc cuda cmake python-scipy python-setuptools python-pytest python-pytest-cov python-pytorch python-pytorch_scatter

nihil39 commented 1 year ago

The error I got depends on the lack of this package: parallel-hashmap. Thanks to Lone Wolf of the Arch Linux forum, see this post

Please add parallel hashmap (and Pytorch?) as dependencies.

acxz commented 1 year ago

Nice finds.

@nihil39 do you want to give a go and writing a PR to try to resolve the issue? I can help you along the way!

nihil39 commented 1 year ago

What is a PR? I think we have to modify the PKGBUILD to require parallel-hashmap and Pytorch as dependencies, maybe parallel-hashmap is only required as a build time dependency and not a runtime one.

acxz commented 1 year ago

So a PR stands for a pull request. It is how you can help me maintain and update the package.

See, by hosting my arch linux PKGBUILDs on github, not only can we comment easily like this via issues; but you can also make the fix to the PKGBUILD yourself and submit it as a change to this repo (PR). As you may know I maintain around hundreds of packages and I may not have time to give all the packages love, so my accepting PRs from the community (i.e. you) it makes my life (and everyone else that uses these packages) easier!

You can start by first forking this repository.

nihil39 commented 1 year ago

So I should fork you repository, add the parallel-hashmap dependency to the python-torch-sparse PKGBUILD and make a pull request to you?

acxz commented 1 year ago

Exactly!

acxz commented 1 year ago

closed with b4ba884