acxz / pkgbuilds

PKGBUILDs for Arch Linux
25 stars 43 forks source link

[python-dm-tree(-git)] fails to build #245

Open moghingold opened 1 year ago

moghingold commented 1 year ago

This is the output of makepkg -i on AUR target python-dm-tree: https://pastebin.com/NUpMyc3t

I get similar results with target python-dm-tree-git. The strange thing is that this package seems to be trying to download and build abseil-cpp, which is available as a separate AUR package (abseil-cpp-git) and had no build issues when I installed it separately.

Is there an upstream issue, or does there seem to be something hinky with my system configuration?

moghingold commented 1 year ago

Very similar output for makepkg -i on AUR target python-dm-tree-git: https://pastebin.com/GkrhpvEM

moghingold commented 1 year ago

Can also now confirm that the problem persists between boots. So if it's an issue with my system state then it isn't a temporary one.

tiagocpontesp commented 1 year ago

can confirm

intelfx commented 1 year ago

Barring the actual problem (CMakeLists.txt seems to be written either incorrectly or at least using deprecated techniques no longer recommended by CMake upstream), abseil-cpp is available as a normal repo package. Thing is, abseil upstream strongly discourages dependents from linking to external copies of abseil. On the other hand, no one has died yet from using the abseil-cpp in Arch repos.

moghingold commented 1 year ago

But I installed abseil-cpp and python-dm-tree still tries to build it anyways. It's not detecting and using the installed version. So the build script seems doubly-wrong. Is there an upstream I should take this info to? Or is this addressable through the PKGBUILD?

intelfx commented 1 year ago

@moghingold yes, it is trying to build its own abseil-cpp unconditionally. This is addressable through the PKGBUILD by de-vendoring abseil, at the cost of making this package dependent on system abseil-cpp.

Alternatively, the build system can be modified to vendor abseil-cpp correctly, but I am uninterested in doing that :)

acxz commented 1 year ago

Keeping this open until the patch is not needed.

acxz commented 1 year ago

patched with #247

xangelix commented 1 year ago

please bump pkgrel in the future to make sure people actually get the fix thank you though!