python-dm-tree: use system abseil-cpp + correctness fixes

intelfx commented 1 year ago

Fixes #245.

moghingold commented 1 year ago

When I try to manually update the files using this PR I get this output:

==> Validating source files with sha256sums...
    python-dm-tree-0.1.8.tar.gz ... Passed
    CMakeLists.txt.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!

When I bypass the validity check for CMakeLists.txt.patch, I get this output:

==> Starting prepare()...
patching file tree/CMakeLists.txt
Hunk #3 FAILED at 62.
1 out of 3 hunks FAILED -- saving rejects to file tree/CMakeLists.txt.rej
==> ERROR: A failure occurred in prepare().
    Aborting...

So it looks like there may be a difference between your local CMakeLists.txt.patch and the one you committed?

Also, please consider making these changes for python-dm-tree-git as well, since it is also affected by #245 .

matiasvlevi commented 1 year ago

I updated the patch with intelfx/acxz-pkgbuilds#1

python-dm-tree is now installed on my system

intelfx commented 1 year ago

@moghingold yep, fixed

moghingold commented 1 year ago

Can confirm these changes worked on my system

acxz commented 1 year ago

@intelfx thx for the fix! LGTM!

acxz / pkgbuilds

python-dm-tree: use system abseil-cpp + correctness fixes #247