search

acxz / pkgbuilds

PKGBUILDs for Arch Linux
25 stars 46 forks source link

[half] Fix a bug in the half.hpp include file not enabling F16C intrinsics correctly when the architecture supports it. #93

Closed DarjanKrijan closed 3 years ago

DarjanKrijan commented 3 years ago

Bug: The immintrin.h header will not be included if HALF_ENABLE_F16C_INTRINSICS wasn't provided manually. HALF_ENABLE_F16C_INTRINSICS though will be set to __F16C__ which compilers (GCC) provide if a proper -march flag is given, so this enables the intrinsics without having included the header above. Compiler errors ensue because things like _mm_set_ss are not declared.

PR fixes this by putting the include directive after HALF_ENABLE_F16C_INTRINSICS being set to __F16C__ which the compiler should set.

Issue mailed to upstream, bug is known but no bugfix release out yet. Keep a look out for next release where this will hopefully be fixed.

Patches #94

DarjanKrijan commented 3 years ago

I don't have a link as I didn't open an issue on sourceforge because I don't have an account on that horrible site.

So I mailed the maintainer Christian Rau directly and got the reply that it is known and fixed internally, but not yet released.

acxz commented 3 years ago

because I don't have an account on that horrible site

lol I feel that, thats a good enough reason for me lol.