search

ad-freiburg / pdfact

A basic tool that extracts the structure from the PDF files of scientific articles.
Apache License 2.0
68 stars 11 forks source link

Minor usability issues #4

Closed hannahbast closed 3 years ago

hannahbast commented 3 years ago

I just used it and found some minor usability issues:

  1. It's unfortunate that one has to be in the install directory to call the script. Isn't there a better solution for this?

  2. With each call, I got the warnings shown in [1] below

  3. In the README.md the "Optional Arguments" box is so wide that one has to scroll back and forth horizontally to read the lines.

  4. It is not clear what the --unit option does before applying it. A bit more explanation would be good.

  5. How are the semantic roles determined? For example, I ran it on a PDF with various headers, but it didn't extract any headers. It would be good to understand, why in prinicple that happened.

[1] Warnings at the beginning when calling ./pdfact 

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.assistedinject.FactoryProvider2$MethodHandleWrapper (file:/local/data/bast/completesearch/applications/enquete/documents/pdfact/bin/pdfact.jar) to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of com.google.inject.assistedinject.FactoryProvider2$MethodHandleWrapper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
hannahbast commented 3 years ago

I just pulled the latest version and the warnings are still there

ckorzen commented 3 years ago

Yeah, I noticed this as well. I assumed that my last commit would fix the problem, but it did not (that's why the issue is still open). The warnings are caused by the Google Guice library and are a common issue which isn't fixed yet. The fix mentioned in this post doesn't work for me.

One option to fix the issue would be to eliminate Google Guice from our project. But that would mean 1-2 days of work.

ckorzen commented 3 years ago

Fixed.