ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
376 stars 45 forks source link

Fix a bug in the `VariableToColumnMap` of `TransitivePath` #1432

Closed joka921 closed 1 month ago

joka921 commented 1 month ago

There was a subtle and long-standing bug in the computation of the result width of a transititve path operation. This is now fixed. This fixes queries like https://qlever.cs.uni-freiburg.de/wikidata/zCHu9V (which without this fix has its third column wrong) and https://qlever.cs.uni-freiburg.de/wikidata/S1XA29 (which without this fix runs into an assertion failue).

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.62%. Comparing base (3a6a791) to head (e879e10). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1432 +/- ## ========================================== - Coverage 89.64% 89.62% -0.03% ========================================== Files 343 343 Lines 29948 29950 +2 Branches 3314 3314 ========================================== - Hits 26848 26842 -6 - Misses 1957 1962 +5 - Partials 1143 1146 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud