search

ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
376 stars 45 forks source link

Fix import of JSON from `SERVICE` call #1440

Closed hannahbast closed 3 weeks ago

hannahbast commented 1 month ago

When reading the JSON from a SERVICE request, literals were unescaped twice. For example, a string "he\\llo" then became the invalid string "he\llo". This is now fixed. Here is an example query: https://qlever.cs.uni-freiburg.de/wikidata/0N1hBD . Fixes #1437

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.51%. Comparing base (87e3329) to head (1fcd787). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1440 +/- ## ======================================= Coverage 89.50% 89.51% ======================================= Files 347 347 Lines 25587 25589 +2 Branches 3439 3439 ======================================= + Hits 22902 22906 +4 Misses 1495 1495 + Partials 1190 1188 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hannahbast commented 3 weeks ago

@joka921 Thanks a lot for adding the test. Looks good to me + I tested it again + revised the PR description. Please feel free to approve and merge