ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
376 stars 45 forks source link

Make AD_EXPECT macros consistent with GTest's EXPECT macros. #1456

Closed RobinTF closed 1 month ago

RobinTF commented 1 month ago

In Googletest there's macros with the EXPECT_ prefix that will continue to execute a test even after failure. In contrast there's also ASSERT_ macros that will immediately stop the respective test. QLever defines some additional test macros prefixed with AD_EXPECT. So far these sometimes behaved like GTests's EXPECT_ and sometimes like ASSERT_. This commit makes these macros consistently behave like EXPECT_ macros, which is also consistent with their naming.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.43%. Comparing base (f986808) to head (8259873). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1456 +/- ## ========================================== - Coverage 89.44% 89.43% -0.01% ========================================== Files 346 346 Lines 25262 25262 Branches 3371 3371 ========================================== - Hits 22595 22594 -1 + Misses 1507 1505 -2 - Partials 1160 1163 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud