Closed joka921 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.45%. Comparing base (
f986808
) to head (fff6810
). Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
QLever uses several global constants defined in the files
Constants.h
andConstantsIndexBuilding.h
. So far, many of them were defined asstatic const
variables, which are prone to the so-called static initialization order fiasco. In particular, this caused unexpected test failures on macOS: This is now fixed by making all these constantsconstexpr
, which makes the initialization order deterministic at compile time. To realize this, there is now a classConstexprString
and a functionconstexprStrCat
for initializingconstexpr std::string_view
variables using compile-time string concatenation.