ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
417 stars 52 forks source link

Make the constructors of `IdTable` SFINAE-friendly #1479

Closed joka921 closed 2 months ago

joka921 commented 2 months ago

Previously std::is_default_constructible<IdTable> was true, but trying to default-construct an IdTable led to a hard compiler error, as the used allocator (the AllocatorWithLimit) was not default constructible. This is now fixed by adding the proper constraints to the constructors of the IdTable class.

joka921 commented 2 months ago

@RobinTF Please try it out, and tell me if that solves your strange compilation issues on MacOS.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.52%. Comparing base (e1cf7d0) to head (f097730). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1479 +/- ## ========================================== + Coverage 89.50% 89.52% +0.02% ========================================== Files 347 347 Lines 25579 25590 +11 Branches 3439 3440 +1 ========================================== + Hits 22895 22910 +15 + Misses 1494 1493 -1 + Partials 1190 1187 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RobinTF commented 2 months ago

That seems to do the trick, thank you.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud