search

ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
417 stars 52 forks source link

Fix result duration computation for lazy results #1480

Closed RobinTF closed 2 months ago

RobinTF commented 2 months ago

This fixes a regression introduced in #1438 that I didn't notice wasn't fixed as part of #1470. The runtime information was wrong for lazy operations (wrong number of rows and wrong times). This is now fixed + a unit tests is added that would have prevented this regression in the first place.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.53%. Comparing base (e1cf7d0) to head (3a219f2). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1480 +/- ## ========================================== + Coverage 89.50% 89.53% +0.03% ========================================== Files 347 347 Lines 25579 25588 +9 Branches 3439 3440 +1 ========================================== + Hits 22895 22911 +16 + Misses 1494 1486 -8 - Partials 1190 1191 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud