Closed UNEXENU closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.15%. Comparing base (
2e47358
) to head (fdb8768
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
I note that MDN says that Media Types are case-insensitive, but are generally written in lower-case. Should there be a normalization of that as well?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#structure_of_a_mime_type
@ahankinson
That is probably a good idea with the lowercasing.
@UNEXENU Can you add a lowercased test (we have a utf-aware to lower function somewhere in StringUtils.h
).
You can then also a unit test for a cased content-type with an additional charset parameter, s.t. this regression would have been found in the first place.
This looks good to me!
@UNEXENU are those commits supposed to be on this branch?
@ahankinson While not directly related to the issue, they're intended to be fixed on this branch.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Fixes #1489. With this fix, QLever again accepts responses of a
SERVICE
request where the content-type has additional fields, e.g.application/sparql-results+json;charset=utf-8
.