ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
376 stars 45 forks source link

Make `SAMPLE` an aggregate expression #1492

Closed joka921 closed 2 weeks ago

joka921 commented 2 weeks ago

So far, SAMPLE was not treated as an aggregate expression, which allowed queries that are not valid according to the SPARQL standard. This is now fixed. In particular, fixes #1485 and #1486 (see there for example queries).

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.14%. Comparing base (a7d6b82) to head (325ba66). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1492 +/- ## ========================================== + Coverage 89.56% 94.14% +4.58% ========================================== Files 347 347 Lines 25605 25623 +18 Branches 3441 3442 +1 ========================================== + Hits 22932 24123 +1191 + Misses 1486 1458 -28 + Partials 1187 42 -1145 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud