Closed joka921 closed 1 month ago
Attention: Patch coverage is 98.63014%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 94.21%. Comparing base (
691439c
) to head (29512bd
). Report is 8 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/engine/CountAvailablePredicates.cpp | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
The
ScanSpecification
class now has two additional members: aLocalVocab
and a set of graphs. TheLocalVocab
enables that one or several of thecol0Id
,col1Id
,col2Id
can be new IRIs or literals (note that our comparators work fine even exactly the same IRI or literal is contained in differentLocalVocab
s). This is important for SPARQL Update. The set of graphs enables filtering of the scan result by one or severval graph IRIs.Also convert
ScanSpecificationAsTripelComponent
toScanSpecification
already in theIndexScan
class (where we already have anIndex
available to convert theTripleComponent
s toId
s). In a future change, we might want to get rid ofScanSpecificationAsTripelComponent
altogether and produce aScanSpecification
right away.On the side, clean up the code and fix several bugs for empty results of index scan operations that only occur with lazy operations.