ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
376 stars 45 forks source link

Fold points directly into the `Id` #1506

Closed ullingerc closed 1 day ago

ullingerc commented 1 week ago

Points (specified by WKT literals with type point) are now stored directly in the ValueId, with 30 bits of precision for each of the two coordinates. This makes working on point geometries (e.g. spatial queries that only work on centroids) orders of magnitude faster, as we save the retrieving of the points from disk as well as parsing them.

ullingerc commented 3 days ago

@joka921 Thank you very much. I have implemented all your reviews and updated the tests. They now all pass. From my part, this PR should now be ready.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 93.28358% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (4c203e2) to head (5326f54). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...sparqlExpressions/SparqlExpressionValueGetters.cpp 57.14% 0 Missing and 3 partials :warning:
src/global/ValueIdComparators.h 0.00% 0 Missing and 2 partials :warning:
src/global/ValueId.h 90.90% 0 Missing and 1 partial :warning:
src/parser/GeoPoint.cpp 98.36% 0 Missing and 1 partial :warning:
src/parser/RdfParser.cpp 83.33% 0 Missing and 1 partial :warning:
src/parser/TripleComponent.h 90.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1506 +/- ## ========================================== - Coverage 92.55% 88.13% -4.43% ========================================== Files 355 357 +2 Lines 26631 26764 +133 Branches 3575 3606 +31 ========================================== - Hits 24649 23588 -1061 - Misses 1940 1942 +2 - Partials 42 1234 +1192 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud