Closed ullingerc closed 1 day ago
@joka921 Thank you very much. I have implemented all your reviews and updated the tests. They now all pass. From my part, this PR should now be ready.
Attention: Patch coverage is 93.28358%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 88.13%. Comparing base (
4c203e2
) to head (5326f54
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Points (specified by WKT literals with type point) are now stored directly in the
ValueId
, with 30 bits of precision for each of the two coordinates. This makes working on point geometries (e.g. spatial queries that only work on centroids) orders of magnitude faster, as we save the retrieving of the points from disk as well as parsing them.