Make parallel parsing the default again for a single input stream

ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.

Apache License 2.0

424 stars 52 forks source link

Make parallel parsing the default again for a single input stream #1585

Closed joka921 closed 3 weeks ago

joka921 commented 4 weeks ago

With the introduction of mutiple input streams (through #1537), the default regarding "parallel-parsing" became "false". That was unfortunate because most existing configurations (in particular, all the Qleverfiles from https://github.com/ad-freiburg/qlever-control) do not set the "parallel-parsing" option explicitly. Without parallel parsing, indexing is much slower. This felt like a regression for many users, for example, see #1563.

This is now fixed as follows: When there is a single input stream, and "parallel-parsing" is neither specified in the settings.json file (which is deprecated) nor on the command line for IndexBuilderMain (new since #1537), then the default is "true". A warning is shown that this is deprecated. The QLever CLI and Qleverfiles from https://github.com/ad-freiburg/qlever-control will be adapted to avoid this deprecated behavior.

sparql-conformance[bot] commented 3 weeks ago

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=cf10c877212e42c57eaf6787ec40220feea5da84&prev=d46e69a2b043c4f0df6586eee29d081d4b58dd0d

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.06%. Comparing base (2ccfb50) to head (cf10c87). Report is 3 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1585 +/- ## ========================================== + Coverage 89.04% 89.06% +0.02% ========================================== Files 368 368 Lines 33972 34047 +75 Branches 3839 3847 +8 ========================================== + Hits 30249 30323 +74 Misses 2471 2471 - Partials 1252 1253 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud