ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
424 stars 52 forks source link

Add cli-arg `service-max-value-rows` #1589

Closed UNEXENU closed 4 weeks ago

UNEXENU commented 1 month ago

Adds the commandline argument service-max-value-rows allowing to set the maximum number of rows passed to a Service operation (see #1341 and #1502 for details). The default value is set to 10,000 rows.

hannahbast commented 1 month ago

@UNEXENU Can't you just always set this via an API call? (with the right access-token, of course)

UNEXENU commented 1 month ago

@hannahbast Yes, an API call works for this too, so the more important change is probably the new default value.

joka921 commented 1 month ago

@hannahbast This was my suggestion. I thought we wanted to have every parameter evenutally as a CLI option to make the starting of QLever a single operation that doesn't need the current "start and then set some things that you cant at startup" workflow.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.08%. Comparing base (39e63b4) to head (e2cdbf4). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1589 +/- ## ======================================= Coverage 89.08% 89.08% ======================================= Files 371 371 Lines 34437 34437 Branches 3899 3899 ======================================= + Hits 30677 30678 +1 + Misses 2486 2484 -2 - Partials 1274 1275 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sparql-conformance[bot] commented 4 weeks ago

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=e2cdbf459604a9933877fff85597982c1bbe14ff&prev=39e63b44de44f5bddd600cb3910cbc63648f565e

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud