ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
424 stars 52 forks source link

Also merge the `LocalBlankNodeManager`s when a `LocalVocab` is merged. #1617

Closed UNEXENU closed 1 day ago

UNEXENU commented 1 week ago

This resolves a bug that was introduced in #1504, where the LocalBlankNodeManager of a LocalVocab was not accounted for in the merge functions of the LocalVocab.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.26%. Comparing base (92d906f) to head (014e7b3).

Files with missing lines Patch % Lines
src/engine/LocalVocab.h 61.11% 5 Missing and 2 partials :warning:
src/util/BlankNodeManager.h 95.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1617 +/- ## ========================================== - Coverage 89.27% 89.26% -0.01% ========================================== Files 374 374 Lines 35610 35657 +47 Branches 4020 4027 +7 ========================================== + Hits 31790 31829 +39 - Misses 2523 2528 +5 - Partials 1297 1300 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

sparql-conformance[bot] commented 1 day ago

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=38b7ac670a3bb4ddc3920a728c940562d687550f&prev=774ea834f5bb496eb96a0120ac8a2062cd6318d9

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud