ad-freiburg / qlever

Very fast SPARQL Engine, which can handle very large knowledge graphs like the complete Wikidata, offers context-sensitive autocompletion for SPARQL queries, and allows combination with text search. It's faster than engines like Blazegraph or Virtuoso, especially for queries involving large result sets.
Apache License 2.0
424 stars 52 forks source link

Add concepts and concrete types where possible for `BlockZipperJoinImpl` #1625

Open RobinTF opened 1 week ago

RobinTF commented 1 week ago

Just a small follow-up to #1616 that narrows down types where possible to avoid having to guess which type is used. Not quite sure if the "SameAsAny" stuff helps readability though.

sparql-conformance[bot] commented 1 week ago

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=c75d100863c1b02418b8a89e15160c837d733b11&prev=55e0617ba75182958fc16579eaad6731b4a54ea2

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (55e0617) to head (c75d100).

Files with missing lines Patch % Lines
src/util/JoinAlgorithms/JoinAlgorithms.h 94.44% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1625 +/- ## ========================================== - Coverage 89.28% 89.28% -0.01% ========================================== Files 374 374 Lines 35608 35613 +5 Branches 4019 4019 ========================================== + Hits 31792 31796 +4 Misses 2520 2520 - Partials 1296 1297 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud