Rename `LOG(...)` macro to `AD_LOG_...` to avoid conflicts with Abseil

joka921 commented 3 days ago

So far, QLever uses the macro LOG(...) for logging, where the argument is the log level. This is used by other libraries, too, in particular by Abseil. With an unfortunate include order, this leads to compilation errors that are hard to understand for new developers. We now use our usual prefix also for logging and call the macros AD_LOG_INFO, AD_LOG_DEBUG, etc.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 61.84211% with 58 lines in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (d53d4f9) to head (2b293d9). Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/index/IndexImpl.cpp	58.99%	57 Missing :warning:
src/util/Log.h	92.30%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1629 +/- ## ========================================== - Coverage 89.25% 89.23% -0.03% ========================================== Files 374 374 Lines 35659 35683 +24 Branches 4027 4027 ========================================== + Hits 31829 31840 +11 - Misses 2529 2537 +8 - Partials 1301 1306 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: