search

ad-m / github-push-action

GitHub actions to push back to repository eg. updated code
MIT License
1.21k stars 229 forks source link

Future of action - consider archiving #104

Open ad-m opened 2 years ago

ad-m commented 2 years ago

I am afraid that this project has little usefulness at the moment, thanks to the development of "actions/checkout", which simplifies the use of tokens. Additionally, getting to know Git better, which indicates that you don't have to use "base64" and your own headers to pass the token further simplifies.

This action is a simple git wrapper that adds an extra (redundant) layer of abstraction. The current open issues are mostly oriented around crossing this abstract layer (with the extreme approach of adding any parameter - see #101) or not understanding git (#99).

I am thinking of archiving this action. Could someone please indicate which operations are not easier for him or at least not possible to do with "actions/checkout" (see example "Push a commit using the built-in token") than with this action?

ad-m commented 2 years ago

@Ale0x78 , Hey, since you have commented in my other semi-public repository, which indicates that you are widely open to open-source collaborations, do you have your opinion on this?

datapolitical commented 2 years ago

So I've been using this action for a while now, and it was because I couldn't figure out how to make "git push" work by itself, and I didn't bother to look at your code to understand why yours worked.

I just figured it out after reading your source (it needed to be HEAD:master not just master), but I have a feeling a lot of people run into the same problem I have.

I think it makes sense to archive it, but I would update the readme with a pretty basic step-by-step of how to use checkout and basic shell commands instead.

So when people come looking for a solution, they will still find one.

NyaMisty commented 2 years ago

I've used this repo everywhere. The reason is that I can simply pass another "github_token" so that I can trigger other github actions workflows from a workflow inside.

heddn commented 2 years ago

We use it to push commits to another github repo.

Repo 1 gets commits. It then merge commits those changes into Repo 2.

kdambekalns commented 2 years ago

Using it to push to another repo than the one triggering the action… also, didn't even consider action/checkout for pushing 🙈

Seeing you can pass a token there, I guess I should check if it does what we need, though.