search

ad-m / github-push-action

GitHub actions to push back to repository eg. updated code
MIT License
1.21k stars 229 forks source link

Compatible with repository addresses using http protocol. #175

Closed kerwin612 closed 1 year ago

kerwin612 commented 1 year ago

Compatible with repository addresses using http protocol.

I am using this action on my company's internal Gitea platform.
Exposed this issue, this PR was tested locally to fix this issue.
Gitea is a Github-like product that can be deployed on a company's local area network(Our internal Gitea instance uses the http protocol.). He implemented a set of fully compatible Github Actions with reference to Github Actions, so we can also use github-push-action;

ZPascal commented 1 year ago

Hi @kerwin612, thank you for the contribution. Do you have already tested it on the Gitea act runners? I've got not a Gitea (without TLS)/ GTE system at the hand the validate this scenario.

kerwin612 commented 1 year ago

Hi @kerwin612, thank you for the contribution. Do you have already tested it on the Gitea act runners? I've got not a Gitea (without TLS)/ GTE system at the hand the validate this scenario.

20230726183138 Yes, this is a must, this PR patch has been running inside us; Perfect compatibility; thank you for open-source this repository.

ZPascal commented 1 year ago

@kerwin612 Glad to hear that. I'll run a classic Github action test on my end. If everything works as expected, I will merge the PR.

stefan-gorules commented 1 year ago

Hi this likely just broke pipeline on our end https://github.com/gorules/zen/actions/runs/5684712114/job/15408012121 under "Push changes"

ZPascal commented 1 year ago

Hi @stefan-gorules, thank you for the notification. I'll revert the change and set up a test case based on your setup.

kerwin612 commented 1 year ago

Hi this likely just broke pipeline on our end https://github.com/gorules/zen/actions/runs/5684712114/job/15408012121 under "Push changes"

see #178 Using https by default can fix your problem