ad-m / github-push-action

GitHub actions to push back to repository eg. updated code
MIT License
1.2k stars 228 forks source link

Not working on Mac #51

Open tofi86 opened 4 years ago

tofi86 commented 4 years ago

I'm running a build on Mac OS and try to push changes back with the following config:

jobs:
  release:
    runs-on: macos-latest
    steps:
    - uses: actions/checkout@v2

    ...

    - name: Set up GitHub Actions git user
      run: |
        git config --local user.email "action@github.com"
        git config --local user.name "GitHub Action"

    - name: do changes
      run: ...

    - name: Push maven-release-plugin changes
      uses: ad-m/github-push-action@v0.5.0
      with:
        tags: true
        github_token: ${{ secrets.GITHUB_TOKEN }}

However, this results in an error:

Push maven-release-plugin changes

Run ad-m/github-push-action@v0.5.0
  with:
    tags: true
    github_token: ***
    branch: master
    directory: .
  env:
    JAVA_HOME: /Users/runner/hostedtoolcache/jdk/8.0.242/x64
    JAVA_HOME_8.0.242_x64: /Users/runner/hostedtoolcache/jdk/8.0.242/x64
##[error]Container action is only supported on Linux

Why is it not supported on Mac OS? Does anyone have a workaround for that?

Thanks for your help and all the best, Tobias

thibautjombart commented 4 years ago

+1 to this; using this in worflows where ubuntu-latest is not supported but MacOS works, so would be very handy to be able to use this action on MacOS environemt too

thibautjombart commented 4 years ago

For what it's worth, the project I would need this for is the real-time analysis of COVID-19 data pipelines for the London School of Hygiene and Tropical Medicine - modelling group.

ad-m commented 4 years ago

What version of action are you using? Could you try ad-m/github-push-action@master? I believe we not longer use container-based action, so issue is no longer valid, but I don't have any experience with GitHub Actions on macOS.

mzabaluev commented 4 years ago

@ad-m If this is fixed, can you make a new release tag? It feels fragile to depend on an action subject to breaking changes in the master branch.

ad-m commented 4 years ago

Could you confirm it is fixed?

mzabaluev commented 4 years ago

@ad-m Works fine on MacOS: https://github.com/mzabaluev/test-github-push/runs/680534681?check_suite_focus=true

mzabaluev commented 4 years ago

Feel free to crib from the workflow in my test repository for testing the action in all environments :grin:

thibautjombart commented 4 years ago

Sorry about the late reply. The current @master works fine. Thanks! :)