search

ad-oliviero / uwufetch

A meme system info tool for Linux, based on nyan/uwu trend on r/linuxmasterrace.
GNU General Public License v3.0
747 stars 48 forks source link

Replacement fix #139

Closed Joshix-1 closed 2 years ago

Joshix-1 commented 2 years ago

This now doesn't use recursion. When using replace_ignorecase now multiple instances get replaced 2021-10-03_12-58

(This could lead to an infinite loop, as the recursion one lead to infinite recursion) .

ad-oliviero commented 2 years ago

Ok it now works on my amd PC, but I still get the segfault on my Intel laptop

Joshix-1 commented 2 years ago

I think I know the problem: When cpu gets replaced with CPUwU the string still contains cpu (ignoring case).

ad-oliviero commented 2 years ago

Yes that's it (sorry for using this pr to test things, but I am too lazy to make a new branch)

Joshix-1 commented 2 years ago

I think you need to do the same for the gpu and apple replacements