search

ad-oliviero / uwufetch

A meme system info tool for Linux, based on nyan/uwu trend on r/linuxmasterrace.
GNU General Public License v3.0
747 stars 48 forks source link

[BUG] Segmentation fault on raspberry pi 3 B+ #154

Closed 4zv4l closed 2 years ago

4zv4l commented 2 years ago

I get a segfault after compiling the code from git and also from yay `(gdb) r Starting program: /home/azz/git/uwufetch/uwufetch [Thread debugging using libthread_db enabled] Using host libthread_db library "/usr/lib/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault. 0x76e9927c in fclose@@GLIBC_2.4 () from /usr/lib/libc.so.6 (gdb)` I didn't more for now to see what cause the seg fault but it used to work before image

4zv4l commented 2 years ago

ok I found the bug in get_info( ) the check for *host_model_info it always fclose( ) the file even if couldn't be opened with the first or second way so ofc it segfault.

4zv4l commented 2 years ago

image

I could remove the bug like this

ad-oliviero commented 2 years ago

Could you send a PR? If you can't I'll update the code tomorrow.

4zv4l commented 2 years ago

Could you send a PR? If you can't I'll update the code tomorrow.

I tried but it says I don't have the right to do a pull request (I'm quiet new to those things so I tried to create a branch locally, do the change and push it but it says I don't have the right) so if you can tell me which way I need to take to do a pull request I would do it with pleasure

ad-oliviero commented 2 years ago

Actually I don't know, I have never sent a pull request, sorry.