ad-oliviero / uwufetch

A meme system info tool for Linux, based on nyan/uwu trend on r/linuxmasterrace.
GNU General Public License v3.0
737 stars 48 forks source link

[OS-SUPPORT] Fix ETC_DIR for unrooted Android/Termux #194

Closed udhcpc closed 2 years ago

udhcpc commented 2 years ago

On unrooted phones this will cause permission denied error. Or we are targeting only rooted Android devices?

udhcpc commented 2 years ago

https://github.com/TheDarkBug/uwufetch/blob/d6ed9130fb2fdfa3c836a526ab90b6a49e2d355c/uwufetch.c#L166 Should I add support for $PREFIX environment variable in config parser here?

ad-oliviero commented 2 years ago

Or we are targeting only rooted Android devices?

No I just forgot to add the variable in the android part

Should I add support for $PREFIX environment variable in config parser here?

Yes If you need help, just ask

udhcpc commented 2 years ago

Done. @TheDarkBug review, please.