[BUG] Buffer overflow on NixOS

ad-oliviero / uwufetch

A meme system info tool for Linux, based on nyan/uwu trend on r/linuxmasterrace.

GNU General Public License v3.0

731 stars 47 forks source link

[BUG] Buffer overflow on NixOS #235

Closed edgess73 closed 1 year ago

edgess73 commented 1 year ago

Describe the bug Buffer overflow detected, when runned

To Reproduce Steps to reproduce the behavior:

Open nix shell with uwufetch
Run uwufetch in terminal

Expected behavior uwufetch will run

Screenshots

Desktop (please complete the following information):

OS: NixOS
Version 23.11 (nixos-unstable) and 23.05 (nixos-stable)

Additional context Overflow happens on my laptop and friend's laptop with NixOS. Package version: 2.1 (from nixpkgs)

Are you already working on this bug? Not working

ad-oliviero commented 1 year ago

I'm rewriting fetch.c, some things may be fixed or broken. The libfetch-rewrite branch will eventually be merged with main, so could you test uwufetch on that branch?

cd uwufetch
git checkout libfetch-rewrite
make
./uwufetch

Thanks

edgess73 commented 1 year ago

It works, but OS is unknown and pkgs are not available.

Thanks!

ad-oliviero commented 1 year ago

Thanks for the feedback.

The os does get recognized, but there is no ascii file for it (partial support). After completing the libfetch rewrite, I'll create an ascii art (if no one makes one before I do).

Packages got fixed in c2882042f78e6c21688256cda725e103b2160486.