search

ad-on-is / lidarr-deemix

44 stars 3 forks source link

Please version the docker images :) #1

Closed Janczykkkko closed 8 months ago

Janczykkkko commented 8 months ago

other than that you're a godsend! thanks, works well with lidarr on steroids!

ad-on-is commented 8 months ago

Yeah, will implement a proper versioning system. Btw... Now it also imports missing artists.

Janczykkkko commented 8 months ago

sounds great! I have been having weird issues tho when using the same arn for deemix and your plugin, indexer was failing in lidarr. Will try to collect all issues into one and report :)

Janczykkkko commented 8 months ago

As for versioning, I highly recommend implementing auto versioning with something like semantic-release and a ci, seems like overkill untill it is a godsend.

ad-on-is commented 8 months ago

As for versioning, I highly recommend implementing auto versioning with something like semantic-release and a ci, seems like overkill untill it is a godsend.

I usually go with the git-tagging system for versioning... So, once I'm confident enough, I tag it, push it and the workflows do their thing with publishing the container, etc...

ad-on-is commented 8 months ago

sounds great! I have been having weird issues tho when using the same arn for deemix and your plugin, indexer was failing in lidarr. Will try to collect all issues into one and report :)

If you mean ARL (instead of arn) - That's strange... I use the same ARL on both, and it works

Janczykkkko commented 8 months ago

ye, I am also using a non standard lidarr setup so I guess it might be a culprit. Anyways, great work mate!

ad-on-is commented 8 months ago

Mine isn't "standard" either :-D It's the plugins-branch with the deemix plugin installed, and a separate deemix-gui container, as you can see in the example docker-compose.