ad-on-is / resticity

A beautiful cross-platform UI for restic backup.
GNU General Public License v3.0
64 stars 2 forks source link

Use a separate secrets file to store passwords and api keys #4

Closed jeremy-lockwood closed 6 months ago

jeremy-lockwood commented 6 months ago

I use a lot of gitops, and would love to add the config.json file to my repo for easy backup/restore. Unfortunately, config.json currently contains passwords and api keys in plain text. It goes without saying that it would be a disaster to commit the file to git.

There are any number of ways to improve this issue, but the simplest would probably be to just have a separate secrets file kept in the same directory as config.jason. The secrets file could be added to .gitignore, and config.json could be committed to git without issue.

ad-on-is commented 6 months ago

Yeah, I thought about the secrets file, but then came to the conclusion, that the config.json should be treated the same way as a secrets file, stored secretly and carefully.

But for people who manage their dotfiles, this would of course make sense.

jeremy-lockwood commented 6 months ago

I appreciate you taking the time to explain your thought process on this! Thank you!

This project is really just crazy awesome, and I'm really excited to be able to use it. I'll be keeping an eye out for if you decide to release an update that lets me keep my config on git. Keep up the awesome work!

ad-on-is commented 6 months ago

I appreciate you taking the time to explain your thought process on this! Thank you!

This project is really just crazy awesome, and I'm really excited to be able to use it. I'll be keeping an eye out for if you decide to release an update that lets me keep my config on git. Keep up the awesome work!

I'll get back to this one for sure, once I've finished the CI/CD and release process, with other minor improvements.

ad-on-is commented 6 months ago

Secrets file is added now for passwords.

jeremy-lockwood commented 6 months ago

hey this is awesome, thank you! any chance you could provide a bit of documentation on how to set it up and required formatting, etc? I'm struggling a bit to figure out how to get it working. It'd be much appreciated!