search

ad-si / brickify

Speed up 3D printing using LEGO® bricks
9 stars 1 forks source link

Feature/separate model cache and samples #646

Closed Steditor closed 9 years ago

Steditor commented 9 years ago

Closes #508

Steditor commented 9 years ago

@adius everything done - pls revisit!

adius commented 9 years ago

One last thing:

adius commented 9 years ago

The reject reason of Promises should always be an instanceof Error

Steditor commented 9 years ago

wontfix in this PR - a big part of our whole system is currently based on using resolve/reject as kind of yes/no answers - if we decide for changing that, we should change the model provider code as well, but that's a new big thing to do.

adius commented 9 years ago

OK. Created an issue for rejecting with errors

See #661