upgrade jest - Githubissues

adRise / update-pr-branch

Github Action to automatically update PR branches that match the criteria. Designed to work with the Github `auto-merge` feature.

MIT License

18 stars 10 forks source link

upgrade jest #28

Closed zhiyelee closed 9 months ago

zhiyelee commented 9 months ago

upgrade jest to latest version

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7997322101

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 7979176448:	0.0%
Covered Lines:	98
Relevant Lines:	98

💛 - Coveralls

zhiyelee commented 9 months ago

@zhiyelee why did the dest/index.js change when you update jest? Should that be just a dev dependency?

Good question. It's embarrassing that I forgot to update dest/index.js for the past two releases. The index.js will be used in the action instead of the source code. I realized this when working on this PR and decided to squeeze it in

nickqi-tubi commented 9 months ago

@zhiyelee why did the dest/index.js change when you update jest? Should that be just a dev dependency?

Good question. It's embarrassing that I forgot to update dest/index.js for the past two releases. The index.js will be used in the action instead of the source code. I realized this when working on this PR and decided to squeeze it in

Do we need to bump up the package version have a new NPM release?