search

ada-discovery / ada-issues

0 stars 0 forks source link

Change minimize/maximize icons to collapse/extend icons to better reflect their functionality #192

Closed gh-osh closed 2 years ago

gh-osh commented 3 years ago

This minimise/maximise buttons do not work.

image

Instance: biomap-ada.lcsb.uni.lu

gh-osh commented 3 years ago

Any comment on this @sherzinger?

sherzinger commented 3 years ago

Confirmed

peterbanda commented 3 years ago

@soumyabrataghosh the widget on the left you are referring to is a tree and you have no nodes (categories) so there is nothing to collapse/expand.

sherzinger commented 3 years ago

Or he understood them the same as me: fit content vs minimise it. I also thought those buttons are buggy. @soumyabrataghosh do you meant to expand a tree or see the full field names?

peterbanda commented 3 years ago

Btw. the whole area is horizontally (as well as vertically) scrollable so it's always possible to see full field names/labels...

sherzinger commented 3 years ago

Considering that 3 different people interpreted those icons wrong, I think a change is in order. They do work, but they don't minimize/maximize, they collapse/extent. I changed the issue title accordingly.

peterbanda commented 3 years ago

Well, the buttons' (current) tooltips are Collapse Alland Expand All :)

LBolzani commented 2 years ago

Hello @soumyabrataghosh I did an update regarding this issue, icons appears only when there are folders/ancestors and not in presence of only tree's leaves. You can test it at: https://10.240.16.149/

sherzinger commented 2 years ago
Screenshot 2021-11-16 at 15 00 14

the icons should be next to each other ideally. In another issue maybe we can also discuss the resizability of that section. It's not very useful with long variable names.

sherzinger commented 2 years ago

And maybe increase the font-size of the icons a tad. They seems a bit too small

gh-osh commented 2 years ago

I would prefer making it a single toggle button like below.. because the action of both buttons is all or none ..

image

LBolzani commented 2 years ago

@sherzinger I increased the icon size, regarding the position usually they stay horizontally, did you decrease window's size? If yes it's normal. @soumyabrataghosh I prefer to stay with two buttons.

sherzinger commented 2 years ago

Screenshot 2021-11-18 at 08 43 24

Really minor, but could you please alter the settings slightly like this? The current oneslooks a bit stretched and pixelated on my screen at least.