search

ada-discovery / ada-issues

0 stars 0 forks source link

Redirect to specific view URL after login #193

Closed gh-osh closed 2 years ago

gh-osh commented 2 years ago

Situation: Someone shares a specific Ada view link to others. Other person is not logged in, she tries to open the link and it asks her to login. Once she sign-in, she is not forwarded to the specific view link. Can we solve this?

gh-osh commented 2 years ago

@sherzinger This is a requirement of Biomap project .. as we are linking Ada to Catalog ..

image

sherzinger commented 2 years ago

@LBolzani can you estimate the effort it takes to do this? I agree with @soumyabrataghosh that this is a bit painful. I think you fixed the same issue already in Podium a while ago, no?

LBolzani commented 2 years ago

Good morning, I'll check, I'll come back as soon as possible

LBolzani commented 2 years ago

@soumyabrataghosh , @sherzinger I did a check. I think with the new deployment there is no problem. With a specific link after login the user is redirected to the selected link.

I've tried with a couple of ones:

Luca

gh-osh commented 2 years ago

Great @LBolzani ..

sherzinger commented 2 years ago

Issue seems to be fixed. Let's include it in the next release alongside a few other changes. Thank you @LBolzani

sherzinger commented 2 years ago

Sorry, I just realized this is already the current version. Well, even better :-)

peterbanda commented 2 years ago

well, this has always worked

gh-osh commented 2 years ago

This has not worked in the older version in Biomap instance at least

On Thu, Nov 11, 2021 at 9:54 AM Peter Banda @.***> wrote:

well, this has always worked

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ada-discovery/ada-issues/issues/193#issuecomment-966104269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4I3EZ353TG6RMLQROEXLULOACRANCNFSM5GLYIGRQ .

peterbanda commented 2 years ago

Hey there. I actually had dozens of bookmarks for production Adas so relied on it quite heavily. I've just tried a local (older) version without OIDC and it worked. Anyway, it's too late to figure out what exactly was wrong.... have a nice weekend

gh-osh commented 2 years ago

Maybe it was some LUMS login issue .. when the user was already logged in.. the url worked .. but not otherwise .. better it is not there anymore .. working as expected

On Fri, Nov 12, 2021 at 2:45 PM Peter Banda @.***> wrote:

Hey there. I actually had dozens on bookmarks for production Adas so relied on it quite heavily. I've just tried a local (older) version without OIDC and it worked. Anyway, it's too late to figure out what exactly was wrong.... have a nice weekend

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ada-discovery/ada-issues/issues/193#issuecomment-967129080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4I3BCNQQBPPTJ2MO3MPTULUK65ANCNFSM5GLYIGRQ .