search

ada-url / ada

WHATWG-compliant and fast URL parser written in modern C++
https://ada-url.com
Apache License 2.0
1.26k stars 77 forks source link

Benchmarks doesn't run on Windows #650

Closed anonrig closed 1 month ago

anonrig commented 1 month ago

We should make our benchmarks run on Windows to open room for optimizations.

cc @lemire

lemire commented 1 month ago

They work for me, except for the part where the Rust integration breaks, but we can just disable it: https://github.com/ada-url/ada/pull/651

lemire commented 1 month ago

@anonrig Does it work for you now that https://github.com/ada-url/ada/pull/651 is merged? If so, I recommend closing this issue. Or changing its title.

anonrig commented 1 month ago

@lemire Thanks. It seems it fixes the issue for me. Currently, cmake detects MSVC as the compiler to build and compile Ada for me on Windows. The question is how do you execute benchmarks on Windows? There is no .exe file?

lemire commented 1 month ago

@anonrig There should be... it should be in build/benchmarks/Release/something.exe or build/benchmarks/Debug/something.exe depending on how you invoked cmake --build (e.g., cmake --build build --config Release or something like it.).

(Note that my instructions can be slightly wrong, I did not check.)

lemire commented 1 month ago

There definitively should .exe files. It slightly different from mac/linux in that you need to specify release/debug and the release/debug files are in different locations.