search

ada-url / ada

WHATWG-compliant and fast URL parser written in modern C++
https://ada-url.com
Apache License 2.0
1.26k stars 77 forks source link

separate fuzzers into different files #655

Closed CarlosEduR closed 1 month ago

anonrig commented 1 month ago

Can you also update build.sh file?

CarlosEduR commented 1 month ago

Can you also update build.sh file?

Sure, I have to run linter as well

CarlosEduR commented 1 month ago

@anonrig we should be able to see the results here, right? https://storage.googleapis.com/oss-fuzz-introspector/ada-url/inspector-report/20240513/fuzz_report.html

Just wanted to confirm it is configured correctly.

anonrig commented 1 month ago

@anonrig we should be able to see the results here, right? https://storage.googleapis.com/oss-fuzz-introspector/ada-url/inspector-report/20240513/fuzz_report.html

@CarlosEduR Yes but they run it on a cronjob. The GitHub workflow is merely for local development and does not cover the whole fuzzer.

Basically, oss-fuzz runs a docker file (implemented in https://github.com/google/oss-fuzz/tree/master/projects/ada-url) which executes build.sh in this repository.

anonrig commented 1 month ago

@CarlosEduR Can you also disable memory sanitizer in a different pull-request if you don't mind?

CarlosEduR commented 1 month ago

@CarlosEduR Can you also disable memory sanitizer in a different pull-request if you don't mind?

sure, @CarlosEduR! From the cifuzz.yml, right?

CarlosEduR commented 1 month ago

@anonrig

image
anonrig commented 1 month ago

@CarlosEduR they are not blocked. they just test a specific portion of the codebase ~0.1%. but this is good progress!

CarlosEduR commented 1 month ago

@CarlosEduR they are not blocked. they just test a specific portion of the codebase ~0.1%. but this is good progress!

thanks for explaining that @anonrig, good to know and glad to help!