search

ada-url / ada

WHATWG-compliant and fast URL parser written in modern C++
https://ada-url.com
Apache License 2.0
1.26k stars 77 forks source link

refactor(ada_c/ada_free_owned_string): remove unused code #673

Closed pratikpc closed 1 month ago

pratikpc commented 1 month ago

Setting parameters of an object passed by value do nothing even at GCC Og level

pratikpc commented 1 month ago

The advantages are purely in readability.

There are no performance gains with optimizations turned on as the compiler can prove that the values are not going to be used whatsoever.

pratikpc commented 1 month ago

Happens to us all LOL