search

ada-url / ada

WHATWG-compliant and fast URL parser written in modern C++
https://ada-url.com
Apache License 2.0
1.26k stars 77 forks source link

Fix ubuntu-22.04 workflow #691

Closed CarlosEduR closed 15 hours ago

CarlosEduR commented 2 days ago

Just debugging this, seems we are having an issue with the ubuntu-22.04 workflow

[49/86] Building CXX object benchmarks/CMakeFiles/benchdata.dir/bench.cpp.o
[50/86] Building CXX object benchmarks/CMakeFiles/bbc_bench.dir/bbc_bench.cpp.o
[51/86] Building CXX object benchmarks/CMakeFiles/percent_encode.dir/percent_encode.cpp.o
[52/86] Linking CXX executable benchmarks/percent_encode
FAILED: benchmarks/percent_encode 
: && /usr/bin/g++-12 -O3 -DNDEBUG  benchmarks/CMakeFiles/percent_encode.dir/percent_encode.cpp.o -o benchmarks/percent_encode  src/libada.a  _deps/benchmark-build/src/libbenchmark.a  -lservo-url  /usr/lib/x86_64-linux-gnu/librt.a && :
/usr/bin/ld: cannot find -lservo-url: No such file or directory
collect2: error: ld returned 1 exit status
[[53](https://github.com/ada-url/ada/actions/runs/9735521594/job/26864830332?pr=691#step:5:54)/86] Building CXX object benchmarks/CMakeFiles/model_bench.dir/model_bench.cpp.o
ninja: build stopped: subcommand failed.
anonrig commented 1 day ago

@lemire can you take a look at this?

CarlosEduR commented 16 hours ago

Not sure if this is the best solution, and also not sure the impact, but seems related to rust, benchmarks and servo-url. 👀