search

ada-url / rust

Rust bindings for Ada URL parser
https://crates.io/crates/ada-url
Apache License 2.0
86 stars 12 forks source link

feat: no-std #42

Closed KSXGitHub closed 1 year ago

KSXGitHub commented 1 year ago

closes https://github.com/ada-url/rust/pull/41

anonrig commented 1 year ago

cc @steveklabnik can you review too?

steveklabnik commented 1 year ago

I would love to but cannot guarantee that I can until Sunday. Maybe earlier but no promises, sorry about that!

KSXGitHub commented 1 year ago

@anonrig

and releasing a new version

Just a reminder that https://github.com/ada-url/rust/pull/37 and https://github.com/ada-url/rust/pull/36 are breaking changes.

Also, the README.md currently contain reference to ada-url's version (version = "1"). You may want to remove that.

anonrig commented 1 year ago

Agree. Can you fix the conflict in this pr @KSXGitHub? I'll release the next version as v2

KSXGitHub commented 1 year ago

Agree. Can you fix the conflict in this pr @KSXGitHub? I'll release the next version as v2

I just pushed the change as the same time as you made this request, it seems.