search

adab1ts / veinapp

Map your vicinity
MIT License
3 stars 3 forks source link

Failing tests #13

Closed zuzust closed 7 years ago

zuzust commented 7 years ago

There is something wrong with testing configuration. We must try to fix it as soon as possible. @sgimeno would you please check it out?

plastikaweb commented 7 years ago

As we talked @zuzust , it is caused by the injection of a service (AngularFire2) in the main component. Any injection must be provided in the test as in the correspondent development module.

I've done 2 tests on geocoding services (see PR #14) @zuzust @sgimeno that are working ok. I've reverted changes on the test.ts file as we talked this morning @zuzust .

zuzust commented 7 years ago

A quick aside @plastikaweb, remember @sgimeno's proposal of conversation: two comments from the same person should merge in a single comment by editing the last one :wink:.

Now, then something is wrong with my development setup because, having reverted changes to test.ts and defined autoWatch: false and singleRun: true in karma.conf.js, karma fails to exit and Chrome remains launched. I have to finish the process closing Chrome window 3 times.

I am on it. But let me ask you, have you got the packages' versions defined in package.json? And which node and npm versions are you using?

plastikaweb commented 7 years ago

Yes, I've got the packages installed and updated and of course the same versions that appear in package.json.

My versions:

Node v7.2.0
npm 4.0.2

Anyway see the comments I've put about this issue in PR #14.