search

adab1ts / veinapp

Map your vicinity
MIT License
3 stars 3 forks source link

Geocoding service #14

Closed plastikaweb closed 7 years ago

plastikaweb commented 7 years ago

See #12 for details.

I've also fixed the ng cz test preventing watching with a new npm script "nowatchtest": "ng test --watch false", I know it was not the place to push it @zuzust @sgimeno, but I wanted to fix it as soon as possible in order to use cz.

plastikaweb commented 7 years ago

Please, review this. I need this to be merged ASAP... Thank you! @zuzust

plastikaweb commented 7 years ago

@zuzust I think we must talk about it. It is not so simple and before doing a huge refactor I want to know exactly what means exactly a 'map.module' and if it means that should be another sibling parents or are you talking about the main app module. My idea was to have 3 modules for the app structure (searching, results and map), another module for services with subfolding and exports by features as is already implemented in services.module (geoservice, geoloc, geocoding...) and another for state management. I think it would be a matter for another personal meeting... If we have the time.

@zuzust Tell me what do you think...

zuzust commented 7 years ago

There are still some regressions. Please, check last commit in master, fix your code, commit your changes and squash your three last commits.