search

adafruit / Adafruit-MAX31855-library

Library for the Adafruit Thermocouple breakout with MAX31855K
http://www.adafruit.com/products/269
Other
101 stars 93 forks source link

Fix begin() and add to examples? #38

Closed caternuson closed 4 years ago

caternuson commented 4 years ago

Probably should have begin() actually return the bool result: https://github.com/adafruit/Adafruit-MAX31855-library/blob/69347a4c8172df2f81cfbab573d80326045aa817/Adafruit_MAX31855.cpp#L80

Also noting that the examples are not calling begin().

Also also - since initialized is private, would it be useful to have a getter for it?

ladyada commented 4 years ago

@caternuson this library could use some luv - maybe also convert it to busio - wanna do that in next few weeks?

caternuson commented 4 years ago

It looks like maybe I already did the busio conversion? Also doxy and actions and some other housekeeping.

This begin() thing is maybe just a little detail that was overlooked?

ladyada commented 4 years ago

oh duh - yeah go for it then. lol i was thinking ot max31865

caternuson commented 4 years ago

Hopefully taken care of with #39