adafruit / Adafruit-MCP23017-Arduino-Library

Arduino Library for Adafruit MCP23017
Other
359 stars 204 forks source link

Turn off Interrupt Triggers and Pull Up Resistors on begin() #55

Closed PsuFan closed 3 years ago

PsuFan commented 3 years ago
ladyada commented 3 years ago

kk please check the CI errors and once passing, tag me to review!

PsuFan commented 3 years ago

@ladyada ugh I have a learning curve on GitHub... I don't know what the problem is. It runs fine for me, I don't know how it could verify with a MCP23017 lol

evaherrada commented 3 years ago

@PsuFan Hey! What GitHub Actions is currently failing on is the clang-format check. You can find out how to install and run that here: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

If you have any questions about doing that, or you find anything confusing, let me know (please @ ping me because there's a much higher chance I'll see it if you do).

Also, don't worry about not knowing GitHub super well. We all had to learn it at some point.

Thanks!

PsuFan commented 3 years ago

@dherrada clang-format returns nothing...

ESP8266 Serial\RFIDDoorSystem>clang-format -i Adafruit_MCP23017.cpp

ESP8266 Serial\RFIDDoorSystem>

evaherrada commented 3 years ago

@PsuFan Looks like you've got some trailing whitespace on lines 12, 16, and 19, although it is pretty odd that clang didn't catch that. Maybe try running it again and then just do it manually if it doesn't fix it.

evaherrada commented 3 years ago

Yeah, it's not supposed to return anything. It just edits the files for you

PsuFan commented 3 years ago

Line 12, 16, 19? I've only added lines 132-138. I'm using Windows and just editing on GitHub.com, I don't have sync setup.

evaherrada commented 3 years ago

@PsuFan Oh yah, you're definitely right. I misread the CI readout

evaherrada commented 3 years ago

@PsuFan The good news is that the clang check is passing. See above for the doxygen (documentation) check.

PsuFan commented 3 years ago

clang-format removed it... Putting it back in now...

evaherrada commented 3 years ago

@PsuFan Looks like it's passing. Good job!

evaherrada commented 3 years ago

@ladyada Am I good to merge?

ladyada commented 3 years ago

close! one request

PsuFan commented 3 years ago

Oops, that wasn't supposed to be in there. That actually gave me increased bandwidth when reading RFID reader!

PsuFan commented 3 years ago

thanks! okay I have one more in examples :S

EDIT: oh that already got pushed, cool. Yeah that was messing me up for a while too. If you miss the FALL event and don't read the interrupt, you don't get any after that.